> On Sept. 26, 2017, 12:02 a.m., Vinod Kone wrote: > > src/master/registry.proto > > Lines 60 (patched) > > <https://reviews.apache.org/r/62477/diff/2/?file=1833357#file1833357line60> > > > > s/master/operator/ ? > > Anand Mazumdar wrote: > hmm, not sure about this. The operator inititates the gone operation but > the master uses its own 'clock' to set the gone time.
I guess you mention "operator" in the comment above `gone` so that's ok. I was mainly concerned because this sentence almost makes it look like it's the master that is marking it gone even though it only relates to time. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62477/#review186178 ----------------------------------------------------------- On Sept. 21, 2017, 8:27 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62477/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2017, 8:27 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-7444 > https://issues.apache.org/jira/browse/MESOS-7444 > > > Repository: mesos > > > Description > ------- > > This change adds the list of gone agents to the registry and also > introduces the `MarkSlaveGone` operation on the Mesos master. This > would be used by the Master Operator API handler to insert an agent > into the list of gone agent. > > Review: https://reviews.apache.org/r/62477 > > > Diffs > ----- > > src/master/master.hpp 05f88111afb4fa0e2baf57106e1479914c16a113 > src/master/registry.proto 362a9fab946e9fb0411df2277f7f3edbadccb61a > src/tests/registrar_tests.cpp b5fc45887e25345d49feb4975f6256cfd7b0fe55 > > > Diff: https://reviews.apache.org/r/62477/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
