-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62638/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer and Jie Yu.
Bugs: MESOS-8027
https://issues.apache.org/jira/browse/MESOS-8027
Repository: mesos
Description
-------
The `O_CLOEXEC` fallback code was broken since it did not guarantee
to include `fcntl.h` before checking for the `O_CLOEXEC` symbol.
O_CLOEXEC is supported by all reasonably current service platforms,
so we should not need to fall back to compatibility code. So rather
than fixing the fallback code, we can just eliminate it.
Diffs
-----
3rdparty/stout/include/stout/os/open.hpp
c9346c62e01688f0f55811f7acbe63321b084355
3rdparty/stout/include/stout/os/windows/fcntl.hpp
ac90bf08ccf5b594e70310e9843475502b3603a5
3rdparty/stout/include/stout/windows.hpp
1d865f8fd23aba0198017f0bf4be8471cfb714ed
src/master/quota.cpp 58bab6a678bac9e41a7994ba0b7cc1ed069a8a18
src/tests/master_quota_tests.cpp f9feb67aba3b8eb56190c9400a5a96f61dd94181
Diff: https://reviews.apache.org/r/62638/diff/1/
Testing
-------
make check (Fedora 26)
Manually verified that sandbox files opened through the webui get the
`O_CLOEXEC` flag applied.
Thanks,
James Peach
