----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62661/#review186663 -----------------------------------------------------------
Fix it, then Ship it! configure.ac Lines 234-238 (patched) <https://reviews.apache.org/r/62661/#comment263462> We currently have two such comment blocks which are not identical, one in `configure.ac` and one in `src/Makefile.am`. I'd suggest to consolidate them into a single block, e.g., in `src/Makefile.am`, and remove the other one. configure.ac Lines 671 (patched) <https://reviews.apache.org/r/62661/#comment263458> Let's break this line to not extend beyond 80 chars, e.g., AM_CONDITIONAL([DISABLE_LIBTOOL_WRAPPERS], [test x"$enable_libtool_wrappers" = "xno"]) src/Makefile.am Line 2551 (original), 2558 (patched) <https://reviews.apache.org/r/62661/#comment263461> This will lead to `mesos-tests` not picking up `AM_LDFLAGS`. We need to remove this line so it is automatically inherited. Otherwise `mesos-tests` is still a wrapper script. - Benjamin Bannier On Sept. 28, 2017, 1:37 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62661/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2017, 1:37 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Kapil > Arya. > > > Bugs: MESOS-7500 > https://issues.apache.org/jira/browse/MESOS-7500 > > > Repository: mesos > > > Description > ------- > > This flag is used to force libtool to generate executables instead of > wrapper scripts. A wrapper script might trigger relinking, which takes > quite a while on slow machines, thus causing failure of tests. > > > Diffs > ----- > > configure.ac 92bc1aa5f9604e3b2b678225a57622cd2eb8679a > src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 > > > Diff: https://reviews.apache.org/r/62661/diff/3/ > > > Testing > ------- > > 1. sudo make check (fedora) > 2. Apache CI (centos 7, ubuntu 14.04) > > > Thanks, > > Andrei Budnik > >
