----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59746/#review186859 -----------------------------------------------------------
src/slave/slave.cpp Lines 5225 (patched) <https://reviews.apache.org/r/59746/#comment263700> Is it "if" or "iff"? In other words, if there are other reasons than framework going away for this future to not be ready, then it doesn't seem correct to not update the metric. src/slave/slave.cpp Lines 5225-5229 (original), 5233-5237 (patched) <https://reviews.apache.org/r/59746/#comment263701> So we no longer log this message if the executor is not present? Why are we suppressing this valuable log? src/slave/slave.cpp Line 5233 (original), 5241 (patched) <https://reviews.apache.org/r/59746/#comment263702> Who destroys the container if the executor struct is not present? Need a comment here on why it is safe. - Vinod Kone On Sept. 27, 2017, 4:47 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59746/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2017, 4:47 p.m.) > > > Review request for mesos, Greg Mann, Ian Downes, Jie Yu, Joseph Wu, Jan > Schlicht, and Vinod Kone. > > > Bugs: MESOS-7601 > https://issues.apache.org/jira/browse/MESOS-7601 > > > Repository: mesos > > > Description > ------- > > The container launch future might be failed or discarded (depending > on the containerizer implementation) if the launch has been aborted, > for example, a framework might have stopped while its task are being > started. Such failures should not be accounted as launch errors. > > > Diffs > ----- > > src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a > > > Diff: https://reviews.apache.org/r/59746/diff/3/ > > > Testing > ------- > > `make check` on several Linux distros. > > Additional manual tests for (1) mesos and (1) docker containerizers. The > framework is asked to exit right after it submits the task to mesos. > > (1) With mesos c-zer > m: `./bin/mesos-master.sh --work_dir=./m` > a: `GLOG_v=1 sudo ./bin/mesos-agent.sh --master=<ip>:5050 --work_dir=./a > --containerizers=mesos --image_providers="DOCKER" > --isolation=filesystem/linux,docker/runtime` > f: `./src/mesos-execute --master=<ip>:5050 --containerizer=mesos > --docker_image=fedora:25 --name=pull-test --command="sleep 1000"` > > (2) With docker c-zer > m: `./bin/mesos-master.sh --work_dir=./m` > a: `GLOG_v=1 sudo ./bin/mesos-agent.sh --master=<ip>:5050 --work_dir=./a > --containerizers=docker` > f: `./src/mesos-execute --master=<ip>:5050 --containerizer=docker > --docker_image=fedora:25 --name=pull-test --command="sleep 1000"` > > > Thanks, > > Alexander Rukletsov > >
