----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62353/#review186879 -----------------------------------------------------------
Patch looks great! Reviews applied: [62655, 62158, 61183, 61528, 62353] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Sept. 25, 2017, 7:42 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62353/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2017, 7:42 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > This patch adds an implementation of the resource provider registrar > backed by the master's registrar. With that it becomes possible to > persist resource provider manager state in a single master registrar, > but use the narrowly defined resource provider registry. > > > Diffs > ----- > > src/master/registry.proto 8916ad30e1d240a177553eaab3a83c0223c268d8 > src/resource_provider/registrar.hpp PRE-CREATION > src/resource_provider/registrar.cpp PRE-CREATION > src/tests/resource_provider_manager_tests.cpp > 3bc56b51526e9dd188423f7349e74246c3295c77 > > > Diff: https://reviews.apache.org/r/62353/diff/8/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
