----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62732/#review186899 -----------------------------------------------------------
Partial skim-review-thing... docs/cmake-examples.md Lines 268 (patched) <https://reviews.apache.org/r/62732/#comment263784> This should have been caught by the linter. docs/cmake.md Lines 42 (patched) <https://reviews.apache.org/r/62732/#comment263774> Hm... The website's markdown generator is not super sophisticated, so I'm not sure if it will render this link correctly. It's ok to go over 80 characters on a line if it's just a URL. docs/cmake.md Lines 50 (patched) <https://reviews.apache.org/r/62732/#comment263775> Ditto here. docs/cmake.md Lines 59-61 (patched) <https://reviews.apache.org/r/62732/#comment263777> Perhaps drop a link to https://cmake.org/cmake/help/v3.7/command/if.html docs/cmake.md Lines 104-105 (patched) <https://reviews.apache.org/r/62732/#comment263782> Odd wrapping here. Start the second line with the `e.g. if (...` docs/cmake.md Lines 188-192 (patched) <https://reviews.apache.org/r/62732/#comment263783> `add_dependencies` isn't actually that rare. We almost always need it whenever we have 2+ targets that are not libraries. Say if you have the `mesos-agent` binary and the `mesos-containerizer` helper binary. Both depend on the `mesos` library to build, but `mesos-agent` depends on `mesos-containerizer` at runtime. (This, BTW, is currently a bug, as we do _not_ have this dependency in place ;) - Joseph Wu On Oct. 2, 2017, 11:55 a.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62732/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2017, 11:55 a.m.) > > > Review request for mesos, Benjamin Bannier, Jeff Coffler, Greg Mann, John > Kordich, James Peach, Joseph Wu, and Li Li. > > > Bugs: MESOS-3107 > https://issues.apache.org/jira/browse/MESOS-3107 > > > Repository: mesos > > > Description > ------- > > This adds a CMake documentation file with best practices, CMake By > Example, and consolidates, fixes, and updates the CMake configuration > options to the configuration documentation. > > > Diffs > ----- > > docs/cmake-examples.md PRE-CREATION > docs/cmake.md PRE-CREATION > docs/configuration-cmake.md d2eb571c9458c7fade415e8077c676dd34e63242 > docs/configuration.md e1fd9f75179b272c3cae3dd5be5e38f269044df5 > > > Diff: https://reviews.apache.org/r/62732/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
