-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62739/#review186911
-----------------------------------------------------------




src/tests/default_executor_tests.cpp
Lines 2392 (patched)
<https://reviews.apache.org/r/62739/#comment263802>

    The interval/grace period settings bellow will make the executor ignore 
failures for the first 10 seconds and retry the check without waiting.
    
    My guess was that 10 seconds should be enough for the task to create the 
file, but we can make the grace period a bit longer.


- Gaston Kleiman


On Oct. 2, 2017, 4:11 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62739/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 4:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7916
>     https://issues.apache.org/jira/browse/MESOS-7916
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test verifies that the command health checks initiated by the
> default executor are able to read files in a persistent volume.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 
> 63952d97b76c3e16973705cb0b16140dd381b7ce 
> 
> 
> Diff: https://reviews.apache.org/r/62739/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo GLOG_v=1 bin/mesos-tests.sh 
> --gtest_filter="*ROOT_HealthCheckUsingPersistentVolume*" --verbose 
> --gtest_repeat=250 --gtest_break_on_failure` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Reply via email to