----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62742/#review186989 -----------------------------------------------------------
Fix it, then Ship it! src/slave/http.cpp Lines 2408-2409 (original), 2408-2409 (patched) <https://reviews.apache.org/r/62742/#comment263938> Should we also mention that a discarded launch (due to the http connection closing and requesting a discard), does not mean the launch was discarded correctly and requires a destroy. Along with a reference to a ticket for that issue? As it stands, it seems a little hard to notice that discarded needs a destroy, I would assume otherwise. src/slave/http.cpp Lines 2415-2418 (original), 2420-2424 (patched) <https://reviews.apache.org/r/62742/#comment263939> The logging seems better, but just to clarify, you're not expecting a discarded to come out here, right? Given that there's no discard requested. - Benjamin Mahler On Oct. 3, 2017, 4 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62742/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2017, 4 a.m.) > > > Review request for mesos, Benjamin Mahler and Zhitao Li. > > > Bugs: MESOS-8039 > https://issues.apache.org/jira/browse/MESOS-8039 > > > Repository: mesos > > > Description > ------- > > Previously, only the failure case is handled. This patch fix the issue > by handling discarded case as well. > > > Diffs > ----- > > src/slave/http.cpp 3ea7829df8c1c35d2fa3a44f19a60b7e261042ce > > > Diff: https://reviews.apache.org/r/62742/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
