----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62548/#review187202 -----------------------------------------------------------
Fix it, then Ship it! This is fantastic, ship it! docs/home.md Lines 98-99 (patched) <https://reviews.apache.org/r/62548/#comment264102> Top of the list. +1 docs/newbie-guide.md Line 37 (original), 26 (patched) <https://reviews.apache.org/r/62548/#comment264103> I think you can make the links to Getting Started relative links, like `[Getting Started](getting-started.md)`. The site generation takes care of making the link work, and this will avoid changes to the top-level domain (and me making comments like, "this should be HTTPS!" because everything should always be HTTPS). docs/newbie-guide.md Lines 39 (patched) <https://reviews.apache.org/r/62548/#comment264104> :D docs/newbie-guide.md Line 66 (original), 53 (patched) <https://reviews.apache.org/r/62548/#comment264105> I love the link to the YouTube video, that will help people out a lot I think. I've tried to explain `libprocess` as "it's just like Erlang processes!" but that wasn't a great explanation if they hadn't used Erlang... docs/submitting-a-patch.md Line 2 (original), 2 (patched) <https://reviews.apache.org/r/62548/#comment264101> I think making this the advanced guide makes a ton more sense. +1 - Andrew Schwartzmeyer On Sept. 25, 2017, 11:02 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62548/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2017, 11:02 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, and Vinod > Kone. > > > Bugs: MESOS-564 > https://issues.apache.org/jira/browse/MESOS-564 > > > Repository: mesos > > > Description > ------- > > Reorganized and updated the contribution guidelines. > > > Diffs > ----- > > docs/home.md f9b35e3e8f9af024a58760c345931d73a83654ff > docs/newbie-guide.md e9f2aaac1bb986120f34b1d006e3a2f5eb2779ff > docs/reopening-reviews.md fe5046830bbdf28fcc2377ffa5792549920afbc8 > docs/reporting-a-bug.md a7e372c1f0d3a34a06244aecb1dfeef7356b8928 > docs/submitting-a-patch.md ffc6e561b8721b8849ef6025c15936ea712d3bfa > site/source/community.html.md f56131fedb935ff695206948e16252c62ae0f36a > > > Diff: https://reviews.apache.org/r/62548/diff/2/ > > > Testing > ------- > > > Thanks, > > Greg Mann > >
