----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60628/#review187238 -----------------------------------------------------------
Patch looks great! Reviews applied: [60291, 60292, 60293, 60294, 60295, 60296, 60297, 60298, 60299, 60300, 60302, 60304, 60305, 60307, 60308, 60310, 60311, 60313, 60314, 60315, 60316, 60317, 60318, 60319, 60320, 60321, 60322, 60323, 60324, 60325, 60326, 60327, 60328, 60329, 60330, 60331, 60332, 60333, 60334, 60335, 60336, 60337, 60338, 60339, 60340, 60341, 60342, 60343, 60344, 60345, 60620, 60621, 60622, 60623, 60624, 60625, 60626, 60628] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 6, 2017, 4:04 a.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60628/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2017, 4:04 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > ------- > > Document that some FetcherTest tests won't work on Windows platform. > Tests for tar, gzip, and such won't be working on Windows for > the time being. Thoughts are to provide this capability to the > Fetcher in a cross-platform manner via a programmatic code library > rather than Linux-specific command line tools (tar, gzip, etc). > > In the short term, zip and unzip will work since PowerShell can > support that natively. > > Fix FetcherTest.AbsoluteCustomSubdirectoryFails on Windows platform. > Test FetcherTest.InvalidUser can't work on Windows for now. > Fix test FetcherTest.NonExistingFile on Windows platform. > Fix test FetcherTest.AbsolutePath on Windows platform. > Fix test FetcherTest.RelativeFilePath on Windows platform. > Fix test FetcherTest.OSNetUriTest on Windows platform. > Fix test FetcherTest.OSNetUriSpaceTest on Windows platform. > Fix test FetcherTest.FileLocalhostURI on Windows platform. > Fix test FetcherTest.Unzip_ExtractFile on Windows platform. > Fix test FetcherTest.Unzip_ExtractInvalidFile on Windows platform. > Fix test Unzip_ExtractFileWithDuplicatedEntries on Windows platform. > Fix test FetcherTest.UseCustomOutputFile on Windows platform. > > > Diffs > ----- > > src/launcher/CMakeLists.txt c7a83d476efe13d65fa529e7676b6488eb48f44b > src/launcher/fetcher.cpp 5a9e93adbf2e4f0b8ff64a69e62fea5f6a0b8f2d > src/slave/containerizer/fetcher.cpp > ba5b0979aa427c5b3dbacf39661d6027da13e0d6 > src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e > src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 > > > Diff: https://reviews.apache.org/r/60628/diff/2/ > > > Testing > ------- > > See upstream. > > > Thanks, > > Jeff Coffler > >
