----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62587/#review187246 -----------------------------------------------------------
include/mesos/authentication/http/authenticatee.hpp Lines 34 (patched) <https://reviews.apache.org/r/62587/#comment264179> In order to keep it consistent with the `Authenticator`, could you add a method which returns the authentication scheme used? i.e. ```c++ /** * Returns the name of the authentication scheme implemented. */ virtual std::string scheme() const = 0; ``` If basic is used, it will return Basic, and so fort. - Alexander Rojas On Oct. 2, 2017, 8:55 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62587/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2017, 8:55 p.m.) > > > Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and > Kapil Arya. > > > Bugs: MESOS-8016 > https://issues.apache.org/jira/browse/MESOS-8016 > > > Repository: mesos > > > Description > ------- > > Added HTTP authenticatee interface definition. > > > Diffs > ----- > > include/mesos/authentication/http/authenticatee.hpp PRE-CREATION > src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 > > > Diff: https://reviews.apache.org/r/62587/diff/4/ > > > Testing > ------- > > Integration test in external project. Further tests upcoming. > > > Thanks, > > Till Toenshoff > >
