----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62594/#review187325 -----------------------------------------------------------
src/scheduler/flags.hpp Lines 22-25 (patched) <https://reviews.apache.org/r/62594/#comment264245> Are these really necessary? src/scheduler/flags.hpp Lines 48 (patched) <https://reviews.apache.org/r/62594/#comment264242> s/http_authenticatee/httpAuthenticatee/ Here and in the variable declaration below. src/scheduler/flags.hpp Lines 112 (patched) <https://reviews.apache.org/r/62594/#comment264244> Newline before the closing curly brace. src/scheduler/scheduler.cpp Lines 226-231 (patched) <https://reviews.apache.org/r/62594/#comment264246> Nit: would prefer if this change went into a separate patch. src/scheduler/scheduler.cpp Lines 331 (patched) <https://reviews.apache.org/r/62594/#comment264247> Should probably indent this line another 4 spaces? - Greg Mann On Oct. 2, 2017, 10:29 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62594/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2017, 10:29 a.m.) > > > Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, > Greg Mann, Kapil Arya, and Vinod Kone. > > > Bugs: MESOS-8021 > https://issues.apache.org/jira/browse/MESOS-8021 > > > Repository: mesos > > > Description > ------- > > Updated scheduler library for modularized HTTP authenticatee use. > > > Diffs > ----- > > src/scheduler/flags.hpp 1e8efc06b40b17d6fa9d9516a83893485804fc72 > src/scheduler/scheduler.cpp 78f53707364ab988bcc53ec2c95490df04cd9a6c > > > Diff: https://reviews.apache.org/r/62594/diff/3/ > > > Testing > ------- > > Integration test in external project. Further tests upcoming. > > > Thanks, > > Till Toenshoff > >
