----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62595/#review187387 -----------------------------------------------------------
src/examples/test_http_authenticator_module.cpp Lines 68 (patched) <https://reviews.apache.org/r/62595/#comment264350> Hmm.. is there a reason that this uses `const mesos::Parameters&`, while the signature of `createHttpAuthenticator` uses `const Parameters&`? - Greg Mann On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62595/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2017, 10:54 p.m.) > > > Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, > Greg Mann, Kapil Arya, and Vinod Kone. > > > Bugs: MESOS-8017 > https://issues.apache.org/jira/browse/MESOS-8017 > > > Repository: mesos > > > Description > ------- > > Added test module wrapping the basic HTTP authenticatee. > > > Diffs > ----- > > src/Makefile.am da8af916652a80303f37b65056920676726f8dfe > src/examples/CMakeLists.txt d4f1af4f072efdc68fa0b722f42b1d8aa1779b6e > src/examples/test_http_authenticator_module.cpp > a2fdc282e741f36a429923a7d6082750a89b7b13 > src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 > src/tests/module.cpp 5b83fd6358ddea4c9d849b8992e1a6040ef74505 > > > Diff: https://reviews.apache.org/r/62595/diff/2/ > > > Testing > ------- > > Integration test in external project. Further tests upcoming. > > > Thanks, > > Till Toenshoff > >
