----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62847/#review187432 -----------------------------------------------------------
Patch looks great! Reviews applied: [62843, 62834, 62847] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 9, 2017, 4:35 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62847/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2017, 4:35 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-8058 > https://issues.apache.org/jira/browse/MESOS-8058 > > > Repository: mesos > > > Description > ------- > > An agent sending an 'UpdateSlaveMessage' including a total can race > with a master sending a 'CheckpointResourcesMessage'. Since > the total in 'UpdateSlaveMessage' is intended to inform the master > about changes to resource provider resources (the resources of the > agent itself are static), and 'CheckpointResourcesMessage' is used by > master not yet capable of offer operation feedback, we here explicitly > disallow combining an agent with resource providers and a master not > supporting offer operation feedback. > > > Diffs > ----- > > src/slave/slave.cpp 2e05637ed10a39eb3f4ce953506b1cb5d50caf3c > src/tests/oversubscription_tests.cpp > 09b4a423a8a9fc543f5456010e7c54919500f78b > > > Diff: https://reviews.apache.org/r/62847/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
