----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62640/#review187524 -----------------------------------------------------------
Ship it! Ship It! - Qian Zhang On Sept. 28, 2017, 8:20 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62640/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2017, 8:20 a.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-7963 > https://issues.apache.org/jira/browse/MESOS-7963 > > > Repository: mesos > > > Description > ------- > > MesosContainerizer was keeping a vector of ContainerLimitation > objects, but in practice it was not possible to have more than one at > a time, since receiving a limitation initiates a container destroy > and new limitations are dropped once the destroy begins. We replace > the vector<ContainerLimition> with a Option<ContainerLimitation>, > but otherwise preserve all the existing semantics. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > cc23b4d91be16fc95a131c09d07378b801e34d6f > src/slave/containerizer/mesos/containerizer.cpp > 4d5dc13f363f5d8886983d7dd06a5cecc177c345 > > > Diff: https://reviews.apache.org/r/62640/diff/2/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >
