----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62642/#review187527 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/containerizer.cpp Lines 1006 (patched) <https://reviews.apache.org/r/62642/#comment264536> In the [this doc](https://github.com/apache/mesos/blob/master/docs/task-state-reasons.md#unused-reasons), I see: > The reasons REASON_CONTAINER_LIMITATION, REASON_INVALID_FRAMEWORKID, REASON_SLAVE_UNKNOWN, REASON_TASK_UNKNOWN and REASON_EXECUTOR_UNREGISTERED are not used as of Mesos 1.4. Since you have used `REASON_TASK_UNKNOWN` in the code here, I think we may need to remove it from the above statement, and change "Mesos 1.4" to "Mesos 1.5", and then put `REASON_TASK_UNKNOWN` into [this table](https://github.com/apache/mesos/blob/master/docs/task-state-reasons.md#for-state-task_failed). - Qian Zhang On Sept. 28, 2017, 8:20 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62642/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2017, 8:20 a.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-7963 > https://issues.apache.org/jira/browse/MESOS-7963 > > > Repository: mesos > > > Description > ------- > > When the MesosContainerizer destroys a container tree, we need to > propagate the ContainerTermination down to all the child containers > so that any executor that is waiting for them can receive enough > information to send a useful status update. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > cc23b4d91be16fc95a131c09d07378b801e34d6f > src/slave/containerizer/mesos/containerizer.cpp > 4d5dc13f363f5d8886983d7dd06a5cecc177c345 > > > Diff: https://reviews.apache.org/r/62642/diff/2/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >
