----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62929/#review187791 -----------------------------------------------------------
include/mesos/mesos.proto Lines 1347 (patched) <https://reviews.apache.org/r/62929/#comment264835> CSI doesn't have "sources" it has "volumes". "This field maps into CSI volume IDs..." would be more appropriate include/mesos/mesos.proto Lines 1351 (patched) <https://reviews.apache.org/r/62929/#comment264836> ditto: s/source/volume/ - James DeFelice On Oct. 12, 2017, 11:39 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62929/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2017, 11:39 a.m.) > > > Review request for mesos, James DeFelice, Jie Yu, and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > This commit adds clarifying documentation to CSI-related proto fields > in `Resource.DiskInfo.Source` which were introduced earlier. > > > Diffs > ----- > > include/mesos/mesos.proto ba87339dbe341f4d16ceea74adc09647a3c07f32 > include/mesos/v1/mesos.proto a6d662fb26aa4f78ef20ffe6e013f7a45f7f8c21 > > > Diff: https://reviews.apache.org/r/62929/diff/1/ > > > Testing > ------- > > NFC. > > > Thanks, > > Benjamin Bannier > >
