----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62880/#review187781 -----------------------------------------------------------
I would much prefer if we'd add another patch before this that modifies the agent to e.g., fail over should it receive a `CheckpointResourcesMessage` and has this capability. Offer operation feedback and `CheckpointResourcesMessage` are incompatible, and we should prevent users from creating inconsistent cluster state. src/tests/master_tests.cpp Lines 4771-4772 (original), 4771-4772 (patched) <https://reviews.apache.org/r/62880/#comment264827> Update the comment as well. src/tests/slave_tests.cpp Lines 1565-1566 (original), 1565-1566 (patched) <https://reviews.apache.org/r/62880/#comment264828> Ditto. - Benjamin Bannier On Oct. 11, 2017, 5:28 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62880/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2017, 5:28 a.m.) > > > Review request for mesos, Benjamin Bannier, Joseph Wu, and Jan Schlicht. > > > Bugs: MESOS-8071 > https://issues.apache.org/jira/browse/MESOS-8071 > > > Repository: mesos > > > Description > ------- > > Marked the agent as RESOURCE_PROVIDER capable. > > > Diffs > ----- > > src/slave/constants.cpp 9b60bd0e808aab272039239db95bee71a3d910ab > src/tests/master_tests.cpp 4c776012e84c34dda7410841e063faab2a84f2df > src/tests/slave_tests.cpp 2ff6daba236972a732618257b25dc3e7fa4dec60 > > > Diff: https://reviews.apache.org/r/62880/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
