----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60467/#review187847 -----------------------------------------------------------
src/slave/posix_signalhandler.hpp Line 37 (original), 38 (patched) <https://reviews.apache.org/r/60467/#comment264886> Could you please remove "called" here since you're touching this function? src/slave/posix_signalhandler.hpp Lines 41-42 (patched) <https://reviews.apache.org/r/60467/#comment264885> Can we use `synchronized` for consistency? - Alexander Rukletsov On June 27, 2017, 2:09 p.m., Dmitry Zhuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60467/ > ----------------------------------------------------------- > > (Updated June 27, 2017, 2:09 p.m.) > > > Review request for mesos, Anand Mazumdar and Avinash sridharan. > > > Bugs: MESOS-6345 > https://issues.apache.org/jira/browse/MESOS-6345 > > > Repository: mesos > > > Description > ------- > > When multiple agents are spawned in a single process, they attempt to install > signal handler concurrently, causing tests, such as > `ExamplesTest.PersistentVolumeFramework` and > `ExamplesTest.DynamicReservationFramework` randomly fail. This adds missing > synchronization to `configureSignal` to resolve the issue. > > > Diffs > ----- > > src/slave/posix_signalhandler.hpp 49692b140662280b9e150654c5f336f1b920586f > > > Diff: https://reviews.apache.org/r/60467/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Dmitry Zhuk > >
