----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62901/#review187877 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/include/process/protobuf.hpp Lines 236-237 (original), 237-238 (patched) <https://reviews.apache.org/r/62901/#comment264910> How about an explicit CHECK_NOTNULL? ``` M* m = CHECK_NOTNULL(google::protobuf::Arena::CreateMessage<M>(&arena)); ``` - Benjamin Mahler On Oct. 12, 2017, 1:10 p.m., Dmitry Zhuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62901/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2017, 1:10 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-6971 > https://issues.apache.org/jira/browse/MESOS-6971 > > > Repository: mesos > > > Description > ------- > > This changes `ProtobufProcess` to use arenas for creating messages. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/protobuf.hpp > e46a076b19de711900f9023ae5c53db45951b547 > > > Diff: https://reviews.apache.org/r/62901/diff/2/ > > > Testing > ------- > > Ran benchmark > ``` > ./benchmarks --gtest_filter=ProcessTest.Process_BENCHMARK_MessagePassing > ``` > before and after changes with the following results: > ``` > Without arenas > [ RUN ] ProcessTest.Process_BENCHMARK_MessagePassing > Size: 4, elapsed: 14.800662ms > Size: 10, elapsed: 23.607056ms > Size: 34, elapsed: 53.234174ms > Size: 64, elapsed: 86.6773ms > Size: 154, elapsed: 191.359858ms > Size: 304, elapsed: 330.10146ms > Size: 605, elapsed: 612.198306ms > Size: 1507, elapsed: 1.515456025secs > Size: 3011, elapsed: 3.006522946secs > Size: 4515, elapsed: 4.532226307secs > Size: 6019, elapsed: 6.045134458secs > Size: 9027, elapsed: 9.077230263secs > Size: 12034, elapsed: 12.156748523secs > Size: 15042, elapsed: 15.199843166secs > Size: 30081, elapsed: 30.394480817secs > [ OK ] ProcessTest.Process_BENCHMARK_MessagePassing (83252 ms) > > > With arenas > [ RUN ] ProcessTest.Process_BENCHMARK_MessagePassing > Size: 4, elapsed: 18.910807ms > Size: 10, elapsed: 28.725021ms > Size: 34, elapsed: 53.235732ms > Size: 64, elapsed: 86.577933ms > Size: 154, elapsed: 157.530026ms > Size: 304, elapsed: 284.589934ms > Size: 605, elapsed: 541.077226ms > Size: 1507, elapsed: 1.311257359secs > Size: 3011, elapsed: 2.591459371secs > Size: 4515, elapsed: 3.879464983secs > Size: 6019, elapsed: 5.168277919secs > Size: 9027, elapsed: 8.265426958secs > Size: 12034, elapsed: 11.087320011secs > Size: 15042, elapsed: 13.854052262secs > Size: 30081, elapsed: 28.361437857secs > [ OK ] ProcessTest.Process_BENCHMARK_MessagePassing (75702 ms) > ``` > > > Thanks, > > Dmitry Zhuk > >
