> On Oct. 12, 2017, 3:04 p.m., Benjamin Bannier wrote: > > include/mesos/mesos.proto > > Lines 958-966 (patched) > > <https://reviews.apache.org/r/62877/diff/1/?file=1852128#file1852128line958> > > > > I do not feel very strongly about this, but it still feels to me that > > this capability is less about resource providers and more about the agent > > being able to provide a protocol for offer operation feedback. > > > > The capability does also show up in e.g., the `/master/slaves` > > endpoint. I could imagine frameworks being interested in looking at this > > capability to follow different logic for offer operation feedback. Still, > > resource providers would not be directly visible to them. > > > > From an implementation point of view, we will add code to the master > > providing differing protocols for offer operations branching on the > > presence of this capability. We again mostly would not care about resource > > providers in that case either.
I agree it's a combination of multiple things, but I think this is OK - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62877/#review187799 ----------------------------------------------------------- On Oct. 11, 2017, 3:24 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62877/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2017, 3:24 a.m.) > > > Review request for mesos, Benjamin Bannier, Joseph Wu, and Jan Schlicht. > > > Bugs: MESOS-8071 > https://issues.apache.org/jira/browse/MESOS-8071 > > > Repository: mesos > > > Description > ------- > > Added RESOURCE_PROVIDER agent capability. > > > Diffs > ----- > > include/mesos/mesos.proto 830985a3265b7c104d8fdc50749c395d98f5f3c8 > include/mesos/v1/mesos.proto a6d662fb26aa4f78ef20ffe6e013f7a45f7f8c21 > src/common/protobuf_utils.hpp ff0fd01b7a20f597ec6cd916f0bd9c41baa5fd51 > src/common/protobuf_utils.cpp 04f44f6f63e431c17ec67e234c8da58e7945294d > > > Diff: https://reviews.apache.org/r/62877/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
