----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63035/#review188154 -----------------------------------------------------------
src/slave/containerizer/mesos/utils.cpp Line 75 (original), 75 (patched) <https://reviews.apache.org/r/63035/#comment265195> I think we can make `ns::getns` return a `Result<ino_t>`. Returnning `None()` means the pid does not exist. - Jie Yu On Oct. 16, 2017, 5:03 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63035/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2017, 5:03 p.m.) > > > Review request for mesos, Alexander Rukletsov, Jie Yu, and Kevin Klues. > > > Bugs: MESOS-7504 > https://issues.apache.org/jira/browse/MESOS-7504 > > > Repository: mesos > > > Description > ------- > > To launch a nested container it might be necessarry to enter parent's > mnt namespace. `getMountNamespaceTarget()` is used for doing that. > > Previously, `getMountNamespaceTarget` returned a failure when a > parent's child or grandchild process exited after enumerating child > processes and before getting mnt namespace for the process. Mesos > containerizer launches pre-exec hooks that might exit when calling > `getMountNamespaceTarget` during a subsequent launch of a > nested container. This commit makes `getMountNamespaceTarget` tolerant > to blinking child processes. > > > Diffs > ----- > > src/slave/containerizer/mesos/utils.cpp > ec6d6c79b0f93cabe880cd697094c20e999af4d1 > > > Diff: https://reviews.apache.org/r/63035/diff/1/ > > > Testing > ------- > > make check > ./src/mesos-tests > --gtest_filter=NestedMesosContainerizerTest.ROOT_CGROUPS_DestroyDebugContainerOnRecover > --gtest_break_on_failure --gtest_repeat=100 > > > Thanks, > > Andrei Budnik > >
