----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63003/#review188157 -----------------------------------------------------------
Ship it! I ended up making roughly the same edit while writing some (HTTP) API tests recently. - Joseph Wu On Oct. 15, 2017, 3:41 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63003/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2017, 3:41 p.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > ------- > > In most cases when a response return code does not match the expected > value, the response body contains the error message. Instead of > adding response body to the macro's output at the call site, change > the macro itself to always include it. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/gtest.hpp > 27077ac9047447fc4c52cc76ab26420e5bc79418 > > > Diff: https://reviews.apache.org/r/63003/diff/1/ > > > Testing > ------- > > See https://reviews.apache.org/r/63015/ > > > Thanks, > > Alexander Rukletsov > >
