----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60621/#review188413 -----------------------------------------------------------
Ship it! Looks good to me other than some funky indentation. Content is fine; decision to not yet introduce `boost::filesystem` is fine. 3rdparty/stout/include/stout/os/posix/copyfile.hpp Lines 38 (patched) <https://reviews.apache.org/r/60621/#comment265406> nit: whitespace 3rdparty/stout/include/stout/os/posix/copyfile.hpp Lines 45-50 (patched) <https://reviews.apache.org/r/60621/#comment265407> nit: indentation 3rdparty/stout/include/stout/os/windows/copyfile.hpp Lines 37 (patched) <https://reviews.apache.org/r/60621/#comment265408> nit: whitespace 3rdparty/stout/include/stout/os/windows/copyfile.hpp Lines 51-55 (patched) <https://reviews.apache.org/r/60621/#comment265409> nit: indentation 3rdparty/stout/tests/os/copyfile_tests.cpp Lines 79 (patched) <https://reviews.apache.org/r/60621/#comment265410> nit: indentation - Andrew Schwartzmeyer On Oct. 16, 2017, 6:16 p.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60621/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2017, 6:16 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > ------- > > The os::copyfile() method provides an API to copy a file from one > location to another. Note that copying of directories are not > supported, and that the destination directory must exist before a > file can be copied into a directory. > > > Diffs > ----- > > 3rdparty/stout/Makefile.am 4386017acd6ca465be3f735460c11d50b440ccc5 > 3rdparty/stout/include/Makefile.am bdd3e9908ebfc682458a3babc34cbee36ad3f751 > 3rdparty/stout/include/stout/os/copyfile.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/posix/copyfile.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/windows/copyfile.hpp PRE-CREATION > 3rdparty/stout/tests/CMakeLists.txt > 6e5773f1e03671de7ac007caf49edd0f1cd7aedd > 3rdparty/stout/tests/os/copyfile_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/60621/diff/4/ > > > Testing > ------- > > See upstream > > Note that Joe made some changes to this, I ended up taking his changes as is. > > > Thanks, > > Jeff Coffler > >
