----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60889/#review188443 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Oct. 16, 2017, 11:27 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60889/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2017, 11:27 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-7305 > https://issues.apache.org/jira/browse/MESOS-7305 > > > Repository: mesos > > > Description > ------- > > Within the containerizer, standalone containers are treated like > any other container (such as those with executors/tasks), so the > MesosContainerizerTests focus on the difference in arguments passed > for standalone containers. > > > Diffs > ----- > > src/tests/containerizer/mesos_containerizer_tests.cpp > e61a85df6ec5308ccd2832e66df803b0ad7b53ee > src/tests/mesos.hpp 24d220e292bc1e137992e8f81484477b62bd0896 > > > Diff: https://reviews.apache.org/r/60889/diff/2/ > > > Testing > ------- > > make check > > NOTE: This test is rather basic because there must be an API in order > to launch standalone containers via the agent (to test recovery of said > containers during agent recovery). The API will be added in subsequent > patches. > > > Thanks, > > Joseph Wu > >
