----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63107/#review188506 -----------------------------------------------------------
FAIL: Failed to apply the dependent review: 62655. Failed command: `python.exe .\support\apply-reviews.py -n -r 62655` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63107 Relevant logs: - [apply-review-62655-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63107/logs/apply-review-62655-stdout.log): ``` error: patch failed: src/master/master.cpp:6782 error: src/master/master.cpp: patch does not apply error: patch failed: src/messages/messages.proto:610 error: src/messages/messages.proto: patch does not apply error: patch failed: src/slave/slave.cpp:1264 error: src/slave/slave.cpp: patch does not apply error: patch failed: src/tests/oversubscription_tests.cpp:323 error: src/tests/oversubscription_tests.cpp: patch does not apply ``` - Mesos Reviewbot Windows On Oct. 18, 2017, 5:39 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63107/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2017, 5:39 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-8087 > https://issues.apache.org/jira/browse/MESOS-8087 > > > Repository: mesos > > > Description > ------- > > When a framework accepts an offer that contains resource provider > resources with a storage operation (`CREATE_VOLUME`, `DESTROY_VOLUME`, > `CREATE_BLOCK`, `DESTROY_BLOCK`), the result of this operation cannot > be guessed and will only be known after the operation has been > successfully applied by the resource provider. > This patch introduces the necessary handling for such operations. The > internal bookkeeping of available resources in the master and agent has > been updated to update resources only after operation feedback has been > received. This ensures that converted resources can only be offered > after the operation was executed by a resource provider. > > > Diffs > ----- > > src/master/master.hpp 0ddc98259f64b3921d08f5f4ec81543bb0826378 > src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6 > src/resource_provider/manager.cpp 31fcb789f5ab907511e868c374c49f7457a33ed3 > src/resource_provider/message.hpp 3c7c3f2baeb726e04edd6ffbb9784699d7afe521 > src/slave/slave.hpp aea1e948209c7c8945665915bc2f6d8eb47814ef > src/slave/slave.cpp 4d7dc8e9a3901b00103031e24e5d6328d0f2e2ad > > > Diff: https://reviews.apache.org/r/63107/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
