----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63183/#review188871 -----------------------------------------------------------
Patch looks great! Reviews applied: [63183] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 20, 2017, 4:27 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63183/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2017, 4:27 p.m.) > > > Review request for mesos, Alexander Rukletsov and Gaston Kleiman. > > > Repository: mesos > > > Description > ------- > > Rather than explicitly waiting for the `connected` scheduler event, > consistently apply the testing pattern from the default executor > tests. We expect that the `connected` event happens, but we only > need to synchronize the test on the `subscribed` event. > > > Diffs > ----- > > src/tests/containerizer/ports_isolator_tests.cpp > 7a19193d2027d51319c3a69a97bfae1fa819845b > > > Diff: https://reviews.apache.org/r/63183/diff/1/ > > > Testing > ------- > > sudo ./mesos-tests --gtest_repeat=10 --gtest_break_on_failure > --gtest_filter=NetworkPorts* > > (Fedora 26) > > > Thanks, > > James Peach > >
