> On Oct. 21, 2017, 12:02 a.m., Michael Park wrote: > > src/master/master.cpp > > Lines 6815 (patched) > > <https://reviews.apache.org/r/63084/diff/1/?file=1860865#file1860865line6815> > > > > I'll update this variable to `message_` before I commit.
Sorry, I think I made a mistake here. Please see the follow-up review. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63084/#review188891 ----------------------------------------------------------- On Oct. 17, 2017, 11:38 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63084/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2017, 11:38 a.m.) > > > Review request for mesos, Benjamin Bannier and Michael Park. > > > Bugs: MESOS-8090 > https://issues.apache.org/jira/browse/MESOS-8090 > > > Repository: mesos > > > Description > ------- > > Fixed a missing transformResources case in master::updateSlave. > > > Diffs > ----- > > src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6 > > > Diff: https://reviews.apache.org/r/63084/diff/1/ > > > Testing > ------- > > Connect a mesos agent from 1.3.1 build with oversubscription enabled to a > master with this patch, and verifies that master can properly update over > subscribed resources. > > Without this patch master crashes like in MESOS-8090. > > > Thanks, > > Zhitao Li > >
