----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63224/#review188985 -----------------------------------------------------------
Ship it! Ship It! - Michael Park On Oct. 23, 2017, 1:52 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63224/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2017, 1:52 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-7726 > https://issues.apache.org/jira/browse/MESOS-7726 > > > Repository: mesos > > > Description > ------- > > This test did not settle the clock before advancing it, which > meant that the call to delay had not yet occurred. > > Also updated the test to avoid retries of the registration > message, which can lead the agent to think it is registered > after a detection event, although this shouldn't be an issue > for this test. > > > Diffs > ----- > > src/tests/master_tests.cpp c6906a752dd70f1d76056b7199af5c27b1e6419b > > > Diff: https://reviews.apache.org/r/63224/diff/1/ > > > Testing > ------- > > Ran in repetition. > > > Thanks, > > Benjamin Mahler > >
