----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63232/#review189119 -----------------------------------------------------------
Fix it, then Ship it! What goes wrong with this issue? Would be good to clarify that in the description. Have you considered a test? src/master/master.cpp Lines 1701-1702 (patched) <https://reviews.apache.org/r/63232/#comment266046> Can you comment on why this is here, for posterity? Something similar to your review description would be helpful! - Benjamin Mahler On Oct. 23, 2017, 11:56 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63232/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2017, 11:56 p.m.) > > > Review request for mesos, Benjamin Mahler and Greg Mann. > > > Bugs: MESOS-7851 > https://issues.apache.org/jira/browse/MESOS-7851 > > > Repository: mesos > > > Description > ------- > > The intention is for us to work with resources in the > `post-reservation-refinement` format > in the master memory, and store them in the master registry or agent > checkpoint in > the `pre` format in order to support downgrades. In this case, we correctly > store the `pre` > format resources in the master registry, but we don't convert them back when > we read it out > of the registry. This patch converts the resources back to `post` when we > read from the registry. > > > Diffs > ----- > > src/master/master.cpp 4b76648b4887724e166ff95e002ee26c8bfef006 > > > Diff: https://reviews.apache.org/r/63232/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Michael Park > >
