----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63280/#review189144 -----------------------------------------------------------
Patch looks great! Reviews applied: [63270, 63280] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 24, 2017, 11:29 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63280/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2017, 11:29 p.m.) > > > Review request for mesos, Benjamin Bannier, Greg Mann, and Jie Yu. > > > Bugs: MESOS-8128 > https://issues.apache.org/jira/browse/MESOS-8128 > > > Repository: mesos > > > Description > ------- > > Since the containerizer launch depends on the inherited pipe to signal > the forked child, be explicit about setting O_CLOEXEC on the pipe file > descriptors. Make sure to close the pipe on the error paths. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 100e3bbda543d87808da9ff6bea42da5099ea8c5 > > > Diff: https://reviews.apache.org/r/63280/diff/1/ > > > Testing > ------- > > make check (Fedora 25) > > > Thanks, > > James Peach > >
