> On Oct. 25, 2017, 4:38 p.m., Gaston Kleiman wrote: > > src/tests/default_executor_tests.cpp > > Lines 1650 (patched) > > <https://reviews.apache.org/r/63253/diff/1/?file=1867546#file1867546line1653> > > > > This should be: > > > > `" if ((Get-Content testFile) -NotMatch 'pizza')"` > > > > To make sure that the file is copied to the sandbox, and that the > > task's working dir is the sandbox. > > Andrew Schwartzmeyer wrote: > This leads into a larger problem on Windows: `shell` tasks are run under > `cmd.exe`, which as a legacy app does not support long paths (actually, it > doesn't even recognize them, it thinks they're UNC paths are bails), so it > falls back to a temp directory. Until we've swapped the default shell on > Windows from `cmd.exe` to `powershell.exe`, this is a problem. The task _is_ > started in the sandbox, but `cmd.exe` then changes directory :( > > All that said, we went the route of using `testFilePath`, the full path > to the file ensure its contents are correct (that the file was copied right). > But you're right, I think it makes more sense to ensure the task was started > in the right place, and then test it relatively. > > Jeff, this means to go back to using `set_shell(false)` etc. to > `powershell.exe` directly, instead of under `cmd.exe`.
Yup, I knew that when I discussed this with Gaston. All set with this. - Jeff ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/#review189204 ----------------------------------------------------------- On Oct. 24, 2017, 6:04 p.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63253/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2017, 6:04 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > ------- > > Fixed changes from Gaston (git commit 772c8f5 on 10/02/2017) > for proper operation on Windows. Changed to use new URI methods > introduced as part of MESOS-6705, and used powershell on Windows > to replace "test" command on Linux. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > 5078bd4d70698f5cbd14c971fcecfd58f8467a04 > > > Diff: https://reviews.apache.org/r/63253/diff/1/ > > > Testing > ------- > > Ran mesos-tests on both Windows and Linux with no errors. > > Specifically ran mesos-tests with > `--gtest_filter=MesosContainerizer/DefaultExecutorTest.*` to verify that the > modified tests ran properly. > > > Thanks, > > Jeff Coffler > >
