> On Oct. 26, 2017, 1:55 p.m., Jeff Coffler wrote: > > 3rdparty/stout/include/stout/windows/os.hpp > > Lines 784 (patched) > > <https://reviews.apache.org/r/63271/diff/1/?file=1869642#file1869642line784> > > > > I usually see NOLINT on a line of it's own. Is that a mistake, making > > the line even longer with `NOLINT`?
As far as I can tell from grepping through the code, it's always at the end of the line that should not be linted. There's one or two places it's by itself, and those are probably wrong. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63271/#review189342 ----------------------------------------------------------- On Oct. 26, 2017, 9:29 a.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63271/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2017, 9:29 a.m.) > > > Review request for mesos, Akash Gupta, Jeff Coffler, Jie Yu, John Kordich, > and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > This is used to set a hard cap on the memory usage for a job object. > > > Diffs > ----- > > 3rdparty/stout/include/stout/windows/os.hpp > 09ddec6d69472cd13b453fe1a77fdbe343fc23c8 > > > Diff: https://reviews.apache.org/r/63271/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
