> On Oct. 20, 2017, 12:44 p.m., Benjamin Bannier wrote: > > src/messages/messages.proto > > Lines 663 (patched) > > <https://reviews.apache.org/r/63094/diff/3/?file=1864433#file1864433line663> > > > > Even though currently operation on agent resources cannot exhibit > > operation speculation failures, I would still prefer would we include some > > version uuid for the agent resources here as well. > > > > AFAICT this could happen either by adjusting `ResourceVersionUUID` so > > that `resource_provider_id` becomes `optional` or by introducing an > > explicit proto3 `map` here, or alternatively, by the agent maintaining its > > own uuid which changes whenever a RP uuid changes and using that uuid > > instead of a vector here (we discussed this offline).
I'll go with making `resource_provider_id` optional. proto3 map does not support a message type key. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63094/#review188829 ----------------------------------------------------------- On Oct. 19, 2017, 9:35 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63094/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2017, 9:35 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao, > Gaston Kleiman, Greg Mann, Joseph Wu, Jan Schlicht, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > The resource version UUID is used to establish the relationship > between the operation and the resources that the operation is > operating on. Each resource provider will keep a resource version > UUID, and changes it when it believes that the resources from this > resource provider are out of sync from the master's view. The master > will keep track of the last known resource version UUID for each > resource provider, and attach the resource version UUID in each > operation it sends out. The resource provider should reject operations > that have a different resource version UUID than that it maintains, > because this means the operation is operating on resources that might > have already been invalidated. > > > Diffs > ----- > > include/mesos/resource_provider/resource_provider.proto > f5a9073075327019fd133bd51265f695ef464845 > include/mesos/v1/resource_provider/resource_provider.proto > e5cbede5b6e57a8641fca1ebfee5454f292cc24c > src/messages/messages.proto 0a32b3457e9143a7d48670610ca3e56dd516136f > src/tests/resource_provider_manager_tests.cpp > ca49e1f0203494fc8b4a4507c33e5a3885a14a59 > src/tests/resource_provider_validation_tests.cpp > f182bff4670318e9de22c2915c5dbb423a74ad6c > > > Diff: https://reviews.apache.org/r/63094/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
