----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63257/#review189555 -----------------------------------------------------------
src/tests/mesos.hpp Lines 995-1037 (patched) <https://reviews.apache.org/r/63257/#comment266681> These implementations are identical but for `type`, and it seems like we should use a single implentation for both with `type` as a function argument or template parameter. - Benjamin Bannier On Oct. 29, 2017, 4:47 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63257/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2017, 4:47 p.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and > Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > Added a few test helpers for creating disk resources. > > > Diffs > ----- > > src/tests/mesos.hpp 4b61f2dbd67a5e8a65a6655519c8f03e5d6c6954 > > > Diff: https://reviews.apache.org/r/63257/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
