----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63356/#review189564 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.cpp Lines 5101 (patched) <https://reviews.apache.org/r/63356/#comment266693> This does not need to be a copy, but can be a `const` ref. src/master/master.cpp Lines 5141 (patched) <https://reviews.apache.org/r/63356/#comment266694> This does not need to be a copy, but can be a `const` ref. src/master/master.cpp Lines 5166 (patched) <https://reviews.apache.org/r/63356/#comment266696> nit: We need to `move` the `Owned` here src/master/master.cpp Lines 5181 (patched) <https://reviews.apache.org/r/63356/#comment266695> This does not need to be a copy, but can be a `const` ref. src/master/master.cpp Lines 5206 (patched) <https://reviews.apache.org/r/63356/#comment266697> nit: We need to `move` the `Owned` here src/master/master.cpp Lines 5246 (patched) <https://reviews.apache.org/r/63356/#comment266698> nit: We need to `move` the `Owned` here - Benjamin Bannier On Oct. 29, 2017, 4:49 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63356/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2017, 4:49 p.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and > Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > While the resource provider manager is responsible to apply offer > operations by sending events to the respective resource providers, > the master takes care of accepting these operations. Hence, for local > resource providers the master sends an `ApplyResourceOperationMessage` > to the agent where the resource provider is running on. The agent > then relays the operation contained in the message to the resource > provider manager. > > (This is based on https://reviews.apache.org/r/61947) > > > Diffs > ----- > > src/common/protobuf_utils.hpp d5fef9c46154196a4e05d094366c0581ba84fd7f > src/common/protobuf_utils.cpp cbb79473c639fba8b21d763097e3b1b2432cef85 > src/master/master.hpp a3c9530e340b14b739da90851227f8eed254b4ac > src/master/master.cpp 5b2c9a006d89265783d49409efd802c62be554f6 > > > Diff: https://reviews.apache.org/r/63356/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
