----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63312/#review189568 -----------------------------------------------------------
Fix it, then Ship it! src/common/resources.cpp Lines 1640 (patched) <https://reviews.apache.org/r/63312/#comment266706> Could we return an `Error` here instead? Right now we only assert for internal invariants, but not for caller-provided information. Here, below, and in the `v1` implementation. src/common/resources.cpp Lines 1798 (patched) <https://reviews.apache.org/r/63312/#comment266707> This should be a `const` ref. src/common/resources.cpp Lines 1814 (patched) <https://reviews.apache.org/r/63312/#comment266708> This should be a `const` ref. src/common/resources.cpp Lines 1830 (patched) <https://reviews.apache.org/r/63312/#comment266709> This should be a `const` ref. src/common/resources.cpp Lines 1846 (patched) <https://reviews.apache.org/r/63312/#comment266710> This should be a `const` ref. src/v1/resources.cpp Lines 1827 (patched) <https://reviews.apache.org/r/63312/#comment266711> This should be a `const` ref. src/v1/resources.cpp Lines 1843 (patched) <https://reviews.apache.org/r/63312/#comment266712> This should be a `const` ref. src/v1/resources.cpp Lines 1859 (patched) <https://reviews.apache.org/r/63312/#comment266713> This should be a `const` ref. src/v1/resources.cpp Lines 1875 (patched) <https://reviews.apache.org/r/63312/#comment266714> This should be a `const` ref. - Benjamin Bannier On Oct. 29, 2017, 4:48 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63312/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2017, 4:48 p.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and > Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > This patch updated Resources::apply method to support new operations: > CREATE_VOLUME, DESTROY_VOLUME, CREATE_BLOCK and DESTROY_BLOCK. We > introduced an optional `convertedResources` field to this method for > new operations. > > This patch also made sure that we don't call Resources::apply for > LAUNCH and LAUNCH_GROUP, because it does not really "convert" the > resources. > > > Diffs > ----- > > include/mesos/resources.hpp 9f959494f5c0376aa4ebd8f2571f4b1f45c83cb3 > include/mesos/v1/resources.hpp a6216858136c82d5ebb5da3bb22c0b8a58a3b75d > src/common/resources.cpp 7ee4dae1389e037531aec533a3d235ee06443ea8 > src/examples/persistent_volume_framework.cpp > 1f8f4bea7ce4d1a919034e0639b4f70e7c9961cf > src/master/allocator/mesos/hierarchical.cpp > 5b6efe5faa3c3b10f1f714f582a155b368f8ccaf > src/v1/resources.cpp 5c0a196cf87b377b345e53a36ed24727d52381ca > > > Diff: https://reviews.apache.org/r/63312/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
