----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63331/#review189677 -----------------------------------------------------------
docs/configuration/agent.md Lines 326 (patched) <https://reviews.apache.org/r/63331/#comment266892> Why do we need this newline? docs/configuration/agent.md Lines 343 (patched) <https://reviews.apache.org/r/63331/#comment266900> Suggest to move `(default: false)` to next line. docs/configuration/agent.md Lines 371 (patched) <https://reviews.apache.org/r/63331/#comment266901> Ditto. docs/isolators/network-ports.md Lines 6 (patched) <https://reviews.apache.org/r/63331/#comment266899> Can you please also describe the bebavior of nested container when this isolator is enabled? docs/upgrades.md Lines 52 (patched) <https://reviews.apache.org/r/63331/#comment266884> s/Added a new `network/ports` isolator/Network ports isolator/ I think we do not need `"Added a new"` because the `"A"` already means this is a newly added feature. docs/upgrades.md Lines 65 (patched) <https://reviews.apache.org/r/63331/#comment266885> s/Added the limitation field to the TaskStatus message/TaskStatus.limitation/ docs/upgrades.md Lines 370 (patched) <https://reviews.apache.org/r/63331/#comment266887> s/A new field, `limitation`, was added/A new field `limitation` was added/ docs/upgrades.md Lines 377 (patched) <https://reviews.apache.org/r/63331/#comment266889> Kill the redundant `the` and add a period in the end. docs/upgrades.md Lines 378 (patched) <https://reviews.apache.org/r/63331/#comment266890> Add a period in the end. - Qian Zhang On Oct. 31, 2017, 8:36 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63331/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2017, 8:36 a.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Added documentation for the `network/ports` isolator to the Mesos > containerizer documentation. Updated the agent flags documentation with > the new isolator flags. Added changelog information to note the new > isolator, the new agent flags and new fields in the TaskStatus message. > > > Diffs > ----- > > docs/configuration/agent.md 5c1b469f28d4a7af0aebad5da65a00dd0e6c2a6c > docs/isolators/network-ports.md PRE-CREATION > docs/mesos-containerizer.md 9cb071273a5ce42784457ea01b363911fdb7773d > docs/upgrades.md 6370c06a497161317884f61f376308423b744fe1 > > > Diff: https://reviews.apache.org/r/63331/diff/1/ > > > Testing > ------- > > Manually checked rendered website. > > > Thanks, > > James Peach > >
