----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63353/#review189861 -----------------------------------------------------------
Per offline discussion, looks like we don't actually need to be clearing it? - Benjamin Mahler On Nov. 1, 2017, 8:53 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63353/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2017, 8:53 p.m.) > > > Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone. > > > Bugs: MESOS-8135 > https://issues.apache.org/jira/browse/MESOS-8135 > > > Repository: mesos > > > Description > ------- > > Previously the agent would sometimes clear the executor ID of > non-command executors before sending the `ReregisterSlaveMessage` > message. > > > Diffs > ----- > > src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070 > > > Diff: https://reviews.apache.org/r/63353/diff/2/ > > > Testing > ------- > > Verified that the new test fails on GNU/Linux without the rest of the patch, > but passes with it. > > > Thanks, > > Gaston Kleiman > >
