----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63468/#review189865 -----------------------------------------------------------
Ship it! Could we avoid the shared pointer per the discussion? By performing the state change before calling `SocketManager::exited`? - Benjamin Mahler On Nov. 1, 2017, 3:17 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63468/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2017, 3:17 p.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Added TERMINATED state to processes. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/process.hpp > dc3375ce62556322eb2bc60ade61f313ade123b8 > 3rdparty/libprocess/src/process.cpp > 71ae7129ffbd0e22eda2863b17bbcf588298c37b > > > Diff: https://reviews.apache.org/r/63468/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
