----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63268/#review189962 -----------------------------------------------------------
3rdparty/stout/include/stout/windows/os.hpp Line 669 (original), 670 (patched) <https://reviews.apache.org/r/63268/#comment267203> How about doing `if (job_handle.get_handle()) {` instead? 3rdparty/stout/include/stout/windows/os.hpp Line 715 (original), 716 (patched) <https://reviews.apache.org/r/63268/#comment267204> Might be a bit cleaner to do `if (!result) {` - Aaron Wood On Nov. 2, 2017, 8:39 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63268/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2017, 8:39 p.m.) > > > Review request for mesos, Aaron Wood, Akash Gupta, Jeff Coffler, Jie Yu, John > Kordich, Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > This changes the CamelCase to snake_case per the style guide for stout. > It also adds `::` to uses of `::GetLastError` where it was missing, and > includes `<vector>` because it was used but missing. > > > Diffs > ----- > > 3rdparty/stout/include/stout/windows/os.hpp > 09ddec6d69472cd13b453fe1a77fdbe343fc23c8 > > > Diff: https://reviews.apache.org/r/63268/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
