----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63273/#review189966 -----------------------------------------------------------
3rdparty/stout/include/stout/windows/os.hpp Lines 793 (patched) <https://reviews.apache.org/r/63273/#comment267213> Do you want to start at 4 here instead? It looks like PID 0 on Windows is the `Idle` process and PID 4 is the `System` process. You could cut down on iteration too by incrementing in multiples of 4. It seems that both thread IDs and process IDs are multiples of 4 https://blogs.msdn.microsoft.com/oldnewthing/20080228-00/?p=23283/ They do mention that you should not rely on this behavior which is too bad. If you could always assume this you could reduce your cycles here. - Aaron Wood On Nov. 2, 2017, 8:40 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63273/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2017, 8:40 p.m.) > > > Review request for mesos, Aaron Wood, Akash Gupta, Jeff Coffler, Jie Yu, John > Kordich, Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Returns a `set<Process>` for all the processes in a job object. > > > Diffs > ----- > > 3rdparty/stout/include/stout/windows/os.hpp > 09ddec6d69472cd13b453fe1a77fdbe343fc23c8 > > > Diff: https://reviews.apache.org/r/63273/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
