----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63423/#review190076 -----------------------------------------------------------
src/launcher/default_executor.cpp Lines 1604 (patched) <https://reviews.apache.org/r/63423/#comment267332> Ah, I had forgotten that we store the authorization header here for use by the checker/health checker, and then the default executor instantiates the executor library, which grabs the token from the environment again. This isn't ideal, but we'll probably have to refactor this anyway when we start to use the authenticatee module here. So, for now we can just eliminate this line and let the executor library unset the env var when it's loaded. Otherwise, the default executor tests fail because the executor library can't authenticate. - Greg Mann On Oct. 30, 2017, 6:15 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63423/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2017, 6:15 p.m.) > > > Review request for mesos and Greg Mann. > > > Bugs: MESOS-8140 > https://issues.apache.org/jira/browse/MESOS-8140 > > > Repository: mesos > > > Description > ------- > > Since the executor may run in the smae container and under > the same credential as the user task, we should clear the > `MESOS_EXECUTOR_AUTHENTICATION_TOKEN` environment variable > once we sample it. > > > Diffs > ----- > > src/executor/executor.cpp 7280951909b677e2a7b0afbcddba4a299dbe6f06 > src/launcher/default_executor.cpp cdb3c3e919a94996bba323fa04bfdc927d537910 > > > Diff: https://reviews.apache.org/r/63423/diff/1/ > > > Testing > ------- > > make check (Fedora 26) > > Manual inspection of child process metadata. > > > Thanks, > > James Peach > >
