----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63550/#review190083 -----------------------------------------------------------
Fix it, then Ship it! support/push-commits.py Lines 48-55 (original), 51-62 (patched) <https://reviews.apache.org/r/63550/#comment267337> Since we're shelling out to `git` multiple times anyway, I think it'd be simpler to just do: ``` reviews = check_output(['git', 'rev-list', '--reverse', merge_base + ".." + current_branch_ref]).split('\n') ``` and then do: ``` for review in reviews: commit_msg = check_output(['git', '--no-pager', 'log', '--no-color', '-n 1', review]) # ... ``` Relying on `--skip` going too far which in turn makes `commit_log` become a empty string and thus checking for `if not commit_log` is more complex than we need it to be I think. - Michael Park On Nov. 3, 2017, 5:40 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63550/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2017, 5:40 p.m.) > > > Review request for mesos, Benjamin Mahler and Michael Park. > > > Repository: mesos > > > Description > ------- > > This script previously closed the reviews without any description. > Now it includes the commit log for easy reference. > > > Diffs > ----- > > support/push-commits.py 3e9d05cb03443e5a46422da67e91d43a119a66c6 > > > Diff: https://reviews.apache.org/r/63550/diff/2/ > > > Testing > ------- > > Tested manually by running in dry run mode. > > > Thanks, > > Vinod Kone > >
