----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63570/#review190115 -----------------------------------------------------------
Ship it! That's funny. - Andrew Schwartzmeyer On Nov. 5, 2017, 5:19 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63570/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2017, 5:19 p.m.) > > > Review request for mesos and Andrew Schwartzmeyer. > > > Repository: mesos > > > Description > ------- > > The debug build was outputting messages such as: > > ``` > gmake[3]: *** No rule to make target > '3rdparty/protobuf-3.3.0/src/protobuf-3.3.0-build/libprotobuf.so', > needed by 'src/libmesos-protobufs.so'. Stop. > gmake[3]: Leaving directory `/home/mpark/projects/mesos/build-debug' > gmake[2]: *** [src/CMakeFiles/mesos-protobufs.dir/all] Error 2 > gmake[2]: *** Waiting for unfinished jobs.... > ``` > > This was due to the fact that `CMAKE_BUILD_TYPE MATCHES DEBUG` does not > evaluate as expected. It needs to be `CMAKE_BUILD_TYPE MATCHES Debug`. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt a37a8c60bc41b4bef95c79d4503e1bbe62551750 > > > Diff: https://reviews.apache.org/r/63570/diff/1/ > > > Testing > ------- > > Successfully ran: > ```bash > cmake -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ > -DCMAKE_BUILD_TYPE=Debug -DCMAKE_EXPORT_COMPILE_COMMANDS=ON .. > cmake --build . --target tests > ``` > > > Thanks, > > Michael Park > >
