-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63569/
-----------------------------------------------------------

(Updated Nov. 5, 2017, 6:04 p.m.)


Review request for mesos and Andrew Schwartzmeyer.


Changes
-------

Also covered `COMPILER_LAUNCHER`.


Bugs: MESOS-6671
    https://issues.apache.org/jira/browse/MESOS-6671


Repository: mesos


Description (updated)
-------

I was building Mesos with `-fsanitize=address` with Clang, and
the build failed because the external dependencies were being
compiled with GCC. `CMAKE_(C|CXX)_FLAGS` are already passed to
the external dependencies, but `CMAKE_(C|CXX)_COMPILER` was not.
This patch adds the `CMAKE_(C|CXX)_COMPILER` bits.


Diffs (updated)
-----

  3rdparty/CMakeLists.txt 6acf0c3eb2cb801dd9f22d82516eeb5c0ebfe3ba 


Diff: https://reviews.apache.org/r/63569/diff/2/

Changes: https://reviews.apache.org/r/63569/diff/1-2/


Testing
-------

Successfully ran:
```bash
cmake -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ 
-DCMAKE_CXX_FLAGS="-fsanitize=address" -DCMAKE_BUILD_TYPE=Debug 
-DCMAKE_EXPORT_COMPILE_COMMANDS=ON ..
cmake --build . --target tests
```


Thanks,

Michael Park

Reply via email to