----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63568/#review190140 -----------------------------------------------------------
include/mesos/slave/containerizer.hpp Line 122 (original), 122 (patched) <https://reviews.apache.org/r/63568/#comment267386> Was this generated by a clang-tidy fixit hint? I suspect not since it changes semantics. Could you split the cleanups and semantics changes into two separate patches? - Benjamin Bannier On Nov. 6, 2017, 1:11 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63568/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2017, 1:11 a.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > ``` > 3rdparty/libprocess/src/../include/process/owned.hpp:117:7: > warning: redundant get() call on smart pointer > [google-readability-redundant-smartptr-get] > ``` > > > Diffs > ----- > > include/mesos/slave/containerizer.hpp > 838a8c394746afb415d00a7764862fb44564f79a > src/master/http.cpp fa0f60cad1f699886df1163ecfd2e34f9154d77f > src/master/master.cpp 49bc50ead75adba82a7d8de23a87b06ccd269c48 > src/slave/http.cpp f2e06aff95e0628624b6ed25de222fd3f3577a0b > src/slave/slave.cpp 79ee163b41ade93cae1054985379d61faf6a081a > src/tests/authorization_tests.cpp f65bf2f89b5c22fb6f366cf3998713f48b52dcd7 > src/tests/containerizer/cni_isolator_tests.cpp > 0d68dd634771c016553313d67ddb33504d1a13c2 > src/tests/containerizer/io_switchboard_tests.cpp > c3410cdbb21b974455d443a18e4af09eddea59ca > src/tests/containerizer/mesos_containerizer_tests.cpp > e61a85df6ec5308ccd2832e66df803b0ad7b53ee > src/tests/containerizer/nested_mesos_containerizer_tests.cpp > fbd2887800ccfd64c8628c5d6fd77a511c8f91d5 > src/tests/hook_tests.cpp 542878210d0d335f504220ac21284a3239f419ee > src/tests/master_tests.cpp 7f4a8073d3ea5dd6ca5fa84171797565eb419e9b > src/tests/partition_tests.cpp 7b11264718b1ab7edbe594335a1f8130bef0236d > src/tests/reconciliation_tests.cpp 8ae2860591afc8eec04b7c23322cd7dd964bbcb3 > src/tests/slave_recovery_tests.cpp db337ba4e213820e7ad0c3f1b480388a2e456556 > src/tests/slave_tests.cpp 9c2db7adf45af4209ecc475d938ce4b77c5a3ab4 > src/uri/fetchers/hadoop.cpp 2fa5b02ac5467a2c0c58cd024a2c8b48c4cea2f0 > > > Diff: https://reviews.apache.org/r/63568/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Michael Park > >
