> On Nov. 3, 2017, 10:19 p.m., Greg Mann wrote: > > src/resource_provider/message.hpp > > Lines 42 (patched) > > <https://reviews.apache.org/r/63491/diff/1/?file=1878544#file1878544line42> > > > > I'm tempted to use `UUID` here instead of `string`, but we would > > probably just end up converting it back immediately in the agent before it > > gets sent to master, so perhaps it's not worth it. What do you think?
I went for a `string` here since a `UUID` cannot be default-constructed, but using a `UUID` turned out to work perfectly fine. Thanks for the suggestion! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63491/#review190064 ----------------------------------------------------------- On Nov. 6, 2017, 1:38 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63491/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2017, 1:38 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > This patch surfaces this information to resource provider manager > users like the agent. In a later patch we will modify the agent to > forward this information to the master. > > > Diffs > ----- > > src/resource_provider/manager.cpp 11f890156f0fd099f8a97b07cdc458a0726ee78e > src/resource_provider/message.hpp 3c7c3f2baeb726e04edd6ffbb9784699d7afe521 > src/tests/slave_tests.cpp 9c2db7adf45af4209ecc475d938ce4b77c5a3ab4 > > > Diff: https://reviews.apache.org/r/63491/diff/2/ > > > Testing > ------- > > `make check`, additional testing as part of > https://reviews.apache.org/r/63496/. > > > Thanks, > > Benjamin Bannier > >
