-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63589/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Benno Evers, and Gilbert Song.
Bugs: MESOS-7506
https://issues.apache.org/jira/browse/MESOS-7506
Repository: mesos
Description
-------
Previously, some tests tried to advance the clock until task status
update was sent, while task's container was destroying. Container
destruction consists of multiple steps, where some steps have a timeout
specified, e.g. `cgroups::DESTROY_TIMEOUT`. So, there was a race
between container destruction process and the loop that advanced the
clock, leading to the following outcomes:
(1) Container destroyed, before clock advancing reaches timeout.
(2) Triggered timeout due to clock advancing, before container
destruction completes. That results in leaving orphaned
containers that will be detected by Slave destructor in
`tests/cluster.cpp`, so the test will fail.
This change gets rid of the loop and resumes clock after a single
advancing of the clock.
Diffs
-----
src/tests/slave_recovery_tests.cpp db337ba4e213820e7ad0c3f1b480388a2e456556
src/tests/slave_tests.cpp 9c2db7adf45af4209ecc475d938ce4b77c5a3ab4
Diff: https://reviews.apache.org/r/63589/diff/1/
Testing
-------
1. make check
2. internal ci (5x)
Thanks,
Andrei Budnik
