----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63591/#review190198 -----------------------------------------------------------
Ship it! Thanks for the cleanup mpark! - Benjamin Bannier On Nov. 6, 2017, 7:54 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63591/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2017, 7:54 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > Since `Shared` is already nullable, avoiding the null state of > a `Shared` and wrapping it in an `Optional` doesn't add anything. > We should just use `Shared` as it is, and make use of the null state. > > > Diffs > ----- > > include/mesos/slave/containerizer.hpp > 838a8c394746afb415d00a7764862fb44564f79a > > > Diff: https://reviews.apache.org/r/63591/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Michael Park > >
